Skip to content

datacatalog

Codecov / codecov/project succeeded Dec 28, 2023 in 0s

59.70% (+1.58%) compared to 81ce71e

View this Pull Request on Codecov

59.70% (+1.58%) compared to 81ce71e

Details

Codecov Report

Attention: 136 lines in your changes are missing coverage. Please review.

Comparison is base (81ce71e) 58.11% compared to head (f5b8f46) 59.70%.

❗ Current head f5b8f46 differs from pull request most recent head 503ff6c. Consider uploading reports for the commit 503ff6c to get more accurate results

Files Patch % Lines
flyteadmin/pkg/manager/impl/execution_manager.go 69.52% 31 Missing and 1 partial ⚠️
flyteadmin/pkg/repositories/gormimpl/common.go 65.90% 10 Missing and 5 partials ⚠️
flyteadmin/pkg/manager/impl/util/shared.go 58.82% 14 Missing ⚠️
flyteadmin/pkg/clusterresource/controller.go 15.38% 11 Missing ⚠️
flyteadmin/pkg/common/resource.go 0.00% 10 Missing ⚠️
...min/pkg/manager/impl/resources/resource_manager.go 82.35% 0 Missing and 9 partials ⚠️
flyteadmin/pkg/manager/impl/util/identifier.go 0.00% 7 Missing ⚠️
...n/pkg/repositories/gormimpl/node_execution_repo.go 71.42% 6 Missing ⚠️
...kg/manager/impl/validation/attributes_validator.go 71.42% 4 Missing ⚠️
flyteadmin/pkg/manager/impl/workflow_manager.go 76.47% 4 Missing ⚠️
... and 14 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4634      +/-   ##
==========================================
+ Coverage   58.11%   59.70%   +1.58%     
==========================================
  Files         626      292     -334     
  Lines       53815    23718   -30097     
==========================================
- Hits        31277    14161   -17116     
+ Misses      20036     8422   -11614     
+ Partials     2502     1135    -1367

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov