Skip to content

refactoring proposal

Codecov / codecov/patch failed Oct 14, 2024 in 1s

10.00% of diff hit (target 36.17%)

View this Pull Request on Codecov

10.00% of diff hit (target 36.17%)

Annotations

Check warning on line 26 in flyteplugins/go/tasks/pluginmachinery/workqueue/mocks/processor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/workqueue/mocks/processor.go#L26

Added line #L26 was not covered by tests

Check warning on line 31 in flyteplugins/go/tasks/pluginmachinery/workqueue/mocks/processor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/workqueue/mocks/processor.go#L31

Added line #L31 was not covered by tests

Check warning on line 15 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/kueue/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/kueue/helper.go#L14-L15

Added lines #L14 - L15 were not covered by tests

Check warning on line 11 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/utils/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/utils/helper.go#L8-L11

Added lines #L8 - L11 were not covered by tests

Check warning on line 19 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/utils/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/utils/helper.go#L16-L19

Added lines #L16 - L19 were not covered by tests

Check warning on line 25 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/utils/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/utils/helper.go#L24-L25

Added lines #L24 - L25 were not covered by tests

Check warning on line 29 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/utils/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/utils/helper.go#L28-L29

Added lines #L28 - L29 were not covered by tests

Check warning on line 45 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go#L23-L45

Added lines #L23 - L45 were not covered by tests

Check warning on line 56 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go#L47-L56

Added lines #L47 - L56 were not covered by tests

Check warning on line 58 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go#L58

Added line #L58 was not covered by tests

Check warning on line 68 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go#L60-L68

Added lines #L60 - L68 were not covered by tests

Check warning on line 73 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go#L70-L73

Added lines #L70 - L73 were not covered by tests

Check warning on line 77 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go#L75-L77

Added lines #L75 - L77 were not covered by tests

Check warning on line 82 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go#L80-L82

Added lines #L80 - L82 were not covered by tests

Check warning on line 87 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go#L84-L87

Added lines #L84 - L87 were not covered by tests

Check warning on line 96 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go#L90-L96

Added lines #L90 - L96 were not covered by tests

Check warning on line 106 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go#L100-L106

Added lines #L100 - L106 were not covered by tests

Check warning on line 110 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go#L108-L110

Added lines #L108 - L110 were not covered by tests

Check warning on line 113 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go#L113

Added line #L113 was not covered by tests

Check warning on line 124 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go#L116-L124

Added lines #L116 - L124 were not covered by tests

Check warning on line 129 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go#L127-L129

Added lines #L127 - L129 were not covered by tests

Check warning on line 132 in flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/batchscheduler/yunikorn/helper.go#L132

Added line #L132 was not covered by tests

Check warning on line 557 in flyteplugins/go/tasks/plugins/k8s/ray/ray.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/ray/ray.go#L556-L557

Added lines #L556 - L557 were not covered by tests

Check warning on line 560 in flyteplugins/go/tasks/plugins/k8s/ray/ray.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/ray/ray.go#L559-L560

Added lines #L559 - L560 were not covered by tests

Check warning on line 571 in flyteplugins/go/tasks/plugins/k8s/ray/ray.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/ray/ray.go#L563-L571

Added lines #L563 - L571 were not covered by tests