Skip to content

Commit

Permalink
Use the rewritten nodes
Browse files Browse the repository at this point in the history
Signed-off-by: Hongxin Liang <[email protected]>
  • Loading branch information
honnix committed Oct 9, 2023
1 parent ab0ceeb commit edd6124
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -384,10 +384,10 @@ public static Map<WorkflowIdentifier, WorkflowTemplate> collectSubWorkflows(
}

public static Map<TaskIdentifier, TaskTemplate> collectDynamicWorkflowTasks(
List<Node> rewrittenNodes,
List<Node> nodes,
Map<TaskIdentifier, TaskTemplate> allTasks,
Function<TaskIdentifier, TaskTemplate> remoteTaskTemplateFetcher) {
return collectTaskIds(rewrittenNodes).stream()
return collectTaskIds(nodes).stream()
// all identifiers should be rewritten at this point
.map(
taskId ->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ private static List<Node> collectTaskTemplates(

Map<TaskIdentifier, TaskTemplate> usedTaskTemplates =
ProjectClosure.collectDynamicWorkflowTasks(
nodes, allTaskTemplates, id -> fetchTaskTemplate(flyteAdminClient, id, cache));
rewrittenNodes, allTaskTemplates, id -> fetchTaskTemplate(flyteAdminClient, id, cache));
allUsedTaskTemplates.putAll(usedTaskTemplates);

return rewrittenNodes;
Expand Down

0 comments on commit edd6124

Please sign in to comment.