Retro fixing all license headers #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
honnix
commented
Sep 26, 2023
| @@ -94,7 +94,7 @@ | |||
| <picocli.version>4.7.2</picocli.version> | |||
| <protobuf.version>3.21.12</protobuf.version> | |||
| <sl4j.version>1.7.36</sl4j.version> | |||
| <spotless.version>2.21.0</spotless.version> | |||
| <spotless.version>2.39.0</spotless.version> | |||
honnix
commented
Sep 26, 2023
| @@ -418,7 +418,7 @@ | |||
| <licenseHeader> | |||
| <!-- Specify either content or file, but not both --> | |||
| <content><![CDATA[/* | |||
| * Copyright $YEAR Flyte Authors | |||
| * Copyright $YEAR Flyte Authors. | |||
honnix
commented
Sep 26, 2023
| @@ -1,3 +1,3 @@ | |||
| version=2.5.2 | |||
| version=3.7.3 | |||
honnix
commented
Sep 26, 2023
pom.xml
Outdated
| @@ -509,6 +509,8 @@ | |||
| <endWithNewline /> | |||
| </format> | |||
| </formats> | |||
|
|
|||
| <ratchetFrom>origin/master</ratchetFrom> | |||
There was a problem hiding this comment.
Looks like we can not use this feature in GitHub Action. This feature is to make sure the year is checked against (or applied with) current year.
There was a problem hiding this comment.
I removed this in a later commit.
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
andresgomezfrr
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR is on top of #245 with additional fix of all file headers, except
package-info.javathat is not supported by spotless.Type
Are all requirements met?
Complete description
This PR also upgrades spotless and scala formatter versions.
Tracking Issue
NA
Follow-up issue
NA