Minor clean up of struct and blob #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honnix
commented
Oct 27, 2023
| @@ -66,6 +66,10 @@ object SdkLiteralTypes { | |||
| datetimes().asInstanceOf[SdkLiteralType[T]] | |||
| case t if t =:= typeOf[Duration] => | |||
| durations().asInstanceOf[SdkLiteralType[T]] | |||
| case t if t =:= typeOf[Blob] => | |||
| blobs(BlobType.DEFAULT).asInstanceOf[SdkLiteralType[T]] | |||
| case t if t <:< typeOf[Product] && !(t =:= typeOf[Option[_]]) => | |||
There was a problem hiding this comment.
Kinda best effort matching, not at all precise. I'm wondering whether this method has to be public as it is not used by anything but test case.
honnix
commented
Oct 27, 2023
| @@ -150,7 +150,10 @@ object SdkBindingDataConverters { | |||
| SdkScalaLiteralTypes.strings(), | |||
| jf.Function.identity() | |||
| ) | |||
| case SimpleType.STRUCT => ??? // TODO not yet supported | |||
| case SimpleType.STRUCT => | |||
There was a problem hiding this comment.
Be explicit that we do not support this intentionally.
Support Scala case class instance to auto-value object (vice versa) is not trivial and it would introduce dependency on flytekit-jackson in one way or another. Hopefully in practice we don't really have need of this.
Signed-off-by: Hongxin Liang <[email protected]>
honnix
force-pushed
the
more-on-struct
branch
from
ecd8c64 to
f3fde3b
Compare
andresgomezfrr
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Minor clean up of struct and blob
Type
Are all requirements met?
Complete description
Mostly getting unit tests in place. I didn't do this in previous PR because we did not realize the test cases are in a dedicated maven module.
Tracking Issue
NA
Follow-up issue
NA