Handle Option correctly #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
honnix
commented
Nov 22, 2023
| value.asInstanceOf[Double].toFloat | ||
| } else if (tpe <:< typeOf[Option[Any]]) { // this has to be before Product check because Option is a Product | ||
| if (value == None) { // None is used to represent Struct.Value.Kind.NULL_VALUE when converting struct to map | ||
| None |
There was a problem hiding this comment.
This is another bug fix. We have been converting things into Some(None), due to type conformation test failure against T in Option[T], which is exactly what this PR set off to fix. Bug on top of bug :(
Hopefully the extended unit tests and ITs cover better.
andresgomezfrr
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Handle Scala
Optioncorrectly by using correct type.Type
Are all requirements met?
Complete description
For case classes like:
the current code doesn't handle typing correctly because calling
param.typeSignature.dealias.typeArgs.head.typeSymbolonOptiontype does not give what we need, and it should beparam.typeSignature.dealias.typeArgs.headinstead.Also we are not handling nested
Optioncorrectly, although in practice there is no good reason to defineOption[Option[String]].Tracking Issue
NA
Follow-up issue
NA