Upgrade a couple of deps #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongxin Liang <[email protected]>
honnix
commented
Dec 28, 2023
| @@ -444,7 +444,6 @@ | |||
| <showWarnings>true</showWarnings> | |||
| <showDeprecation>true</showDeprecation> | |||
| <forceJavacCompilerUse>true</forceJavacCompilerUse> | |||
| <failOnWarning>true</failOnWarning> | |||
There was a problem hiding this comment.
This is a hard decision. See google/auto#870. It makes no sense to add @SuppressWarnings("rawtype") everywhere in the code base, and it is more dangerous to set -Averify=false (plus I barely got it working; it worked in one module but not in another and I had no clue why).
pablocasares
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Upgrade a couple of deps reported by Synk
Type
Are all requirements met?
Complete description
Closes #256
Closes #255
Closes #229
Tracking Issue
NA
Follow-up issue
NA