support python 3.11 #1557
Merged
support python 3.11 #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy
requested review from
wild-endeavor,
kumare3,
eapolinario and
pingsutw
as code owners
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1557 +/- ##
=========================================
Coverage 69.58% 69.59%
=========================================
Files 311 311
Lines 28916 28918 +2
Branches 2755 5252 +2497
=========================================
+ Hits 20122 20126 +4
+ Misses 8281 8276 -5
- Partials 513 516 +3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Niels Bantilan <[email protected]>
eapolinario
reviewed
Mar 22, 2023
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
wild-endeavor
previously approved these changes
Mar 22, 2023
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| microlib_name = f"flytekitplugins-{PLUGIN_NAME}" | |||
|
|
|||
| plugin_requires = ["flytekit>=1.3.0b2,<2.0.0", "great-expectations>=0.13.30", "sqlalchemy>=1.4.23"] | |||
| plugin_requires = ["flytekit>=1.3.0b2,<2.0.0", "great-expectations>=0.13.30", "sqlalchemy>=1.4.23,<2.0.0"] | |||
There was a problem hiding this comment.
needed? or just nice to have?
There was a problem hiding this comment.
needed, since GE doesn't support sqlalchemy 2+ yet
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy
force-pushed
the
flytekit-python-3.11
branch
from
3e65515 to
b276bcb
Compare
Signed-off-by: Niels Bantilan <[email protected]>
wild-endeavor
previously approved these changes
Mar 23, 2023
Signed-off-by: Niels Bantilan <[email protected]>
wild-endeavor
previously approved these changes
Mar 23, 2023
Signed-off-by: Niels Bantilan <[email protected]>
|
Note: this may also address flyteorg/flyte#2115 (?) |
wild-endeavor
approved these changes
Mar 24, 2023
pingsutw
approved these changes
Mar 27, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixes flyteorg/flyte#3312. This PR makes the necessary changes to support python 3.11
It also addresses flyteorg/flyte#3166, removing the old numpy dtype aliases.
Type
Are all requirements met?
Complete description
See TLDR
Tracking Issue
flyteorg/flyte#3312
Follow-up issue
NA