Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Flytekit runtime metrics to S3 #1683

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Yicheng-Lu-llll
Copy link
Member

@Yicheng-Lu-llll Yicheng-Lu-llll commented Jun 8, 2023

TL;DR

This is part of Flytekit Metrics Exploration.

This PR uploads all the flytekit metrics to the remote storage(highlighted in green).
image

Flytekit Metrics Exploration includes:

Checks

ran task in the sand box, the span file is under the same folder with deck.html.
image
image

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #1683 (9c8c2ee) into master (3370a96) will increase coverage by 0.00%.
The diff coverage is 73.91%.

❗ Current head 9c8c2ee differs from pull request most recent head 767335a. Consider uploading reports for the commit 767335a to get more accurate results

@@           Coverage Diff           @@
##           master    #1683   +/-   ##
=======================================
  Coverage   71.03%   71.03%           
=======================================
  Files         336      336           
  Lines       30798    30813   +15     
  Branches     5589     5590    +1     
=======================================
+ Hits        21876    21889   +13     
- Misses       8375     8378    +3     
+ Partials      547      546    -1     
Impacted Files Coverage Δ
flytekit/core/base_task.py 48.32% <ø> (ø)
flytekit/core/constants.py 0.00% <0.00%> (ø)
flytekit/deck/deck.py 52.63% <66.66%> (ø)
flytekit/core/utils.py 62.37% <83.33%> (+2.14%) ⬆️

... and 4 files with indirect coverage changes

@Yicheng-Lu-llll Yicheng-Lu-llll force-pushed the Flytekit-Metrics-Exploration branch from 163259e to 9c8c2ee Compare June 13, 2023 22:14
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
@Yicheng-Lu-llll Yicheng-Lu-llll force-pushed the Flytekit-Metrics-Exploration branch from 9c8c2ee to cc51a28 Compare June 14, 2023 01:44
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant