Inputs outputs wrapper #2075
Inputs outputs wrapper #2075
Conversation
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
| return literal_models.LiteralMap.from_flyte_idl( | ||
| utils.load_proto_from_file(literals_pb2.LiteralMap, tmp_name) | ||
| ) | ||
| proto_type, value = utils.load_one_proto_from_file(tmp_name, literals_pb2.InputData, |
There was a problem hiding this comment.
interesting that we had to only change here,
did you update the getData method in flyteadmin, if so, this will need an additional if
flytekit/flytekit/remote/remote.py
Line 273 in 452a2ec
| @@ -700,6 +700,40 @@ def from_flyte_idl(cls, pb2_object): | |||
| return cls({k: Literal.from_flyte_idl(v) for k, v in pb2_object.literals.items()}) | |||
|
|
|||
|
|
|||
| class OutputData(_common.FlyteIdlEntity): | |||
There was a problem hiding this comment.
maybe you should add a new property called
@property
def literals() -> Dict[str, Literal]:
...
This is to mimic -
flytekit/flytekit/models/literals.py
Line 681 in 452a2ec
Otherwise, things like this will be missed IMO
flytekit/flytekit/remote/remote.py
Line 1880 in 452a2ec
you have handled it fine here as you convert to literalmap
|
i think this PR needs a few rounds of testing |
|
I don't think it's complete, I agree... I only tested inputs/outputs for an execution... if you have scenarios in mind for testing, that would help a lot.. |
Tracking issue
flyteorg/flyte#4654
Why are the changes needed?
Allow flytekit to pass additional information in outputs that can be propagated to the UI/flyteadmin and used in subsequent tasks..
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link