Fix type hint

[pingsutw]

Tracking issue

Before:

After:

Why are the changes needed?

What changes were proposed in this pull request?

Get warning in IDE

Update type hint.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1127206) 85.26% compared to head (7cc4e81) 85.78%.
Report is 54 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2118      +/-   ##
==========================================
+ Coverage   85.26%   85.78%   +0.52%     
==========================================
  Files         290      313      +23     
  Lines       22334    23512    +1178     
  Branches     3512     3515       +3     
==========================================
+ Hits        19042    20169    +1127     
- Misses       2684     2734      +50     
- Partials      608      609       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ringohoffman]

What was the error you were seeing?

[pingsutw]

[eapolinario]

We shouldn't do this. This effectively removes typing information from tasks.

[pingsutw]

We shouldn't do this. This effectively removes typing information from tasks.

is there any way to fix it? current typing information is wrong.

[ringohoffman]

Seems like it got its return type from flyte_entity_call_handler:

flytekit/flytekit/core/promise.py

Lines 1132 to 1134 in cba830e

	def flyte_entity_call_handler(
	entity: SupportsNodeCreation, *args, **kwargs
	) -> Union[Tuple[Promise], Promise, VoidPromise, Tuple, Coroutine, None]:

also there is a type: ignore comment on the return of Task.__call__. Maybe we can start with making sure this signature is as expected.

It seems like you have another workflow called train you are saying returns a str, but Task.__call__ never references the user's declared return type. On which of the paths does it return the result of the underlying function?

[pingsutw]

@ringohoffman here