Replace Agent State with Agent Phase

[Future-Outlier]

Tracking issue

Fixes flyteorg/flyte#3936

Why are the changes needed?

1. We want to deprecate State in webapi and use core.TaskExecution.Phase instead to make users less confused.
2. We want to print the agent's metadata when using local execution continuously.

What changes were proposed in this pull request?

• Change variables and functions below.

1. cur_state -> cur_phase
2. return Resource(state=...) -> return Resource(phase=...)
3. admin state -> propeller phase
4. mmcloud_status_to_flyte_state -> mmcloud_status_to_flyte_phase
5. convert_to_flyte_state -> convert_to_flyte_phase

• move the printing of the local agent's metadata to be inside the while loop.
  https://github.com/flyteorg/flytekit/blob/master/flytekit/extend/backend/base_agent.py#L261-L264

How was this patch tested?

• local agent task execution
• remote agent task execution
• unit test

Setup process

0. start agent server by flytekit
1. start flyte components with --dev
2. compile and start the flyte cluster
3. run a remote task with sensor agent

pyflyte serve agent

flytectl demo start --dev

cd flyte
make compile;
flyte start --config ../flyte-single-binary-local-dev.yaml

pyflyte run --remote sensor_example.py wf

tasks:
  task-plugins:
    enabled-plugins:
      - agent-service

plugins:
  agent-service:
    supportedTaskTypes:
      - sensor
    defaultAgent:
      endpoint: "dns:///localhost:8000"
      insecure: true
      timeouts:
        GetTask: 100s
      defaultTimeout: 100s

from flytekit.sensor.file_sensor import FileSensor
from flytekit import ImageSpec, task, workflow
sensor = FileSensor(name="test_sensor")

@task()
def t1():
    return

@workflow()
def wf():
    sensor(path="/tmp") >> t1()

if __name__ == "__main__":
    wf()

Screenshots

• Remote Execution
  

• Local Execution
  

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

flyteorg/flyte#4738

[codecov]

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (b230f3e) 85.79% compared to head (de4675e) 85.57%.
Report is 6 commits behind head on master.

Files	Patch %	Lines
flytekit/extend/backend/base_agent.py	73.33%	2 Missing and 2 partials ⚠️
.../flytekit-airflow/flytekitplugins/airflow/agent.py	50.00%	4 Missing ⚠️
...lytekit-bigquery/flytekitplugins/bigquery/agent.py	83.33%	1 Missing ⚠️
...tekit-snowflake/flytekitplugins/snowflake/agent.py	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2123      +/-   ##
==========================================
- Coverage   85.79%   85.57%   -0.23%     
==========================================
  Files         313      308       -5     
  Lines       23628    23113     -515     
  Branches     3541     3540       -1     
==========================================
- Hits        20272    19779     -493     
+ Misses       2744     2722      -22     
  Partials      612      612              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Future-Outlier]

[pingsutw]

do we really new hasattr here?

[Future-Outlier]

do we really new hasattr here?

will remove it, thank you