Fix: Handle overriding of container image in backend #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
3 tasks
|
Tests are failing because an idl upgrade is needed once flyteorg/flyte#4858 is merged. |
fg91
changed the title
fg91
requested review from
wild-endeavor,
kumare3,
eapolinario and
cosmicBboy
as code owners
dosubot
bot
added
the
size:M
pingsutw
approved these changes
Feb 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2176 +/- ##
==========================================
- Coverage 85.86% 84.65% -1.21%
==========================================
Files 314 314
Lines 24042 24048 +6
Branches 3643 3644 +1
==========================================
- Hits 20643 20359 -284
- Misses 2759 3037 +278
- Partials 640 652 +12 ☔ View full report in Codecov by Sentry. |
added 2 commits
February 29, 2024 22:24
Signed-off-by: Fabio Grätz <[email protected]>
Signed-off-by: Fabio Grätz <[email protected]>
fg91
force-pushed
the
fg91/fix/handle-container-image-override-in-backend
branch
from
26be842 to
e68a4e8
Compare
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Handle overriding of container image in backend Signed-off-by: Fabio Grätz <[email protected]> * Adapt tests Signed-off-by: Fabio Grätz <[email protected]> --------- Signed-off-by: Fabio Grätz <[email protected]> Co-authored-by: Fabio Grätz <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#4543
Why are the changes needed?
The
container_imagetask node override, among others, is currently broken (doesn't work withpyflyte registerand only once withpyflyte run, see tracking issue.What changes were proposed in this pull request?
Don't override container image of
run_entityin.with_overridesbut actually in flyteidl'sTaskNodeOverrideso that the container image is overridden in the backend.How was this patch tested?
In combination with flyteorg/flyte#4858 I ensured that the resulting pod in the cluster has the correct image. I also adapted the unit tests.
Related PRs
flyteorg/flyte#4858
Docs link