-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FlyteFS #2208
Fix FlyteFS #2208
Conversation
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2208 +/- ##
==========================================
- Coverage 85.99% 83.31% -2.68%
==========================================
Files 320 309 -11
Lines 24246 24011 -235
Branches 3666 3478 -188
==========================================
- Hits 20850 20005 -845
- Misses 2745 3384 +639
+ Partials 651 622 -29 ☔ View full report in Codecov by Sentry. |
This solution looks like it's papering over the problem. Why is this specific to Azure? I have a feeling that either stow is not returning the etag in https://github.com/flyteorg/flyte/blob/6f5c47154549dd9f697f4a44547eda5197d40a52/flyteadmin/dataproxy/service.go#L83 or Azure is not returning the etag in that specific case (a HEAD request to fill |
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Tracking issue
NA
Why are the changes needed?
Failed to upload the FlyteFile to ABFS
What changes were proposed in this pull request?
Add additional metadata to the request header
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Blocked by flyteorg/flyte#4971
Docs link
NA