Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FlyteFS #2208

Merged
merged 17 commits into from
Mar 12, 2024
Merged

Fix FlyteFS #2208

merged 17 commits into from
Mar 12, 2024

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Feb 23, 2024

Tracking issue

NA

Why are the changes needed?

Failed to upload the FlyteFile to ABFS

What changes were proposed in this pull request?

Add additional metadata to the request header

How was this patch tested?

pyflyte --verbose run --remote test2.py wf --f test/test.csv --d test
import pandas as pd

from flytekit import task, workflow
from flytekit.types.directory import FlyteDirectory
from flytekit.types.file import FlyteFile


@task()
def print_data_directory(f: FlyteFile, d: FlyteDirectory):
    df = pd.read_csv(f)
    print(d)
    print(df.head())


@workflow
def wf(f: FlyteFile, d: FlyteDirectory):
    print_data_directory(f=f, d=d)

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Blocked by flyteorg/flyte#4971

Docs link

NA

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 83.31%. Comparing base (d7c6029) to head (88614ff).
Report is 22 commits behind head on master.

Files Patch % Lines
flytekit/remote/remote_fs.py 0.00% 4 Missing ⚠️
flytekit/clients/friendly.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2208      +/-   ##
==========================================
- Coverage   85.99%   83.31%   -2.68%     
==========================================
  Files         320      309      -11     
  Lines       24246    24011     -235     
  Branches     3666     3478     -188     
==========================================
- Hits        20850    20005     -845     
- Misses       2745     3384     +639     
+ Partials      651      622      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario
Copy link
Collaborator

eapolinario commented Feb 23, 2024

This solution looks like it's papering over the problem. Why is this specific to Azure? I have a feeling that either stow is not returning the etag in https://github.com/flyteorg/flyte/blob/6f5c47154549dd9f697f4a44547eda5197d40a52/flyteadmin/dataproxy/service.go#L83 or Azure is not returning the etag in that specific case (a HEAD request to fill metadata).

wild-endeavor
wild-endeavor previously approved these changes Feb 23, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by maintainer label Feb 23, 2024
@pingsutw pingsutw marked this pull request as draft February 23, 2024 22:22
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw changed the title Upload FlyteFile to ABFS from local Fix FlyteFs Feb 27, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw marked this pull request as ready for review February 28, 2024 11:42
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 28, 2024
@pingsutw pingsutw changed the title Fix FlyteFs Fix FlyteFS Feb 28, 2024
wild-endeavor
wild-endeavor previously approved these changes Feb 28, 2024
Copy link
Contributor

@wild-endeavor wild-endeavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

flytekit/remote/remote_fs.py Outdated Show resolved Hide resolved
flytekit/remote/remote.py Show resolved Hide resolved
flytekit/remote/remote_fs.py Outdated Show resolved Hide resolved
pingsutw added 2 commits March 4, 2024 03:10
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Mar 5, 2024
Signed-off-by: Kevin Su <[email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 11, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw merged commit 7144ae9 into master Mar 12, 2024
45 of 47 checks passed
austin362667 pushed a commit to austin362667/flytekit that referenced this pull request Mar 16, 2024
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants