Adapt flytekit ray plugin to kuberay 1.1.0 #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByronHsu
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
dosubot
bot
added
size:S
pingsutw
reviewed
Mar 20, 2024
Signed-off-by: Pin-Lun Hsu <[email protected]>
Signed-off-by: Pin-Lun Hsu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2274 +/- ##
==========================================
- Coverage 83.76% 83.36% -0.41%
==========================================
Files 329 311 -18
Lines 25002 24193 -809
Branches 3708 3496 -212
==========================================
- Hits 20943 20168 -775
+ Misses 3432 3398 -34
Partials 627 627 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pin-Lun Hsu <[email protected]>
Signed-off-by: Pin-Lun Hsu <[email protected]>
pingsutw
approved these changes
Mar 25, 2024
|
let's merge flyteidl first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description is consolidated at flyteorg/flyte#5067. Also, need to wait for flyte PR merged because this PR relies on flyte PR's flyteidl change