-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support async workflow & task #2611
Open
novahow
wants to merge
9
commits into
flyteorg:master
Choose a base branch
from
novahow:feature/flyteRun
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novahow
force-pushed
the
feature/flyteRun
branch
2 times, most recently
from
August 15, 2024 12:46
e0aeaf3
to
9bc6d89
Compare
novahow
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
August 15, 2024 12:47
novahow
force-pushed
the
feature/flyteRun
branch
from
August 24, 2024 21:55
e9440f2
to
e9a62ce
Compare
Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]>
Signed-off-by: novahow <[email protected]>
novahow
force-pushed
the
feature/flyteRun
branch
from
September 5, 2024 20:15
e9a62ce
to
c0fa654
Compare
OMG!!!!!!!!!!! This is amazing stuff. But we have to take closer look at the code. @thomasjpfan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
closes flyteorg/flyte#1840
Why are the changes needed?
support async task.
pythonfunctiontask
,pythonfunctionworkflow
andmap_task
are supported.Conditional workflows
are currently not supportedWhat changes were proposed in this pull request?
Added an
awaitable
attribute inPromise
andVoidPromise
How was this patch tested?
added unit tests on map_task and promises.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link