-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default execution name should be generated in flyteadmin #2678
Default execution name should be generated in flyteadmin #2678
Conversation
Signed-off-by: wayner0628 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2678 +/- ##
===========================================
- Coverage 79.24% 46.21% -33.03%
===========================================
Files 196 187 -9
Lines 19785 19196 -589
Branches 4008 2774 -1234
===========================================
- Hits 15678 8871 -6807
- Misses 3407 9888 +6481
+ Partials 700 437 -263 ☔ View full report in Codecov by Sentry. |
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Tracking issue
Why are the changes needed?
flytekit
should not generate execution name, but send an empty string and letflyteadmin
generateWhat changes were proposed in this pull request?
execution_name
to an empty string, see the implementation hereHow was this patch tested?
unit testing
Setup process
Screenshots
Check all the applicable boxes
Related PRs
flyteorg/flyte#5637
Docs link