-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify dependencies in agent image #3008
Conversation
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
….io/flyteorg/flyteagent:1.14.0 pyflyte serve agent --port 8000 --timeout 1` in a gh workflow works Signed-off-by: Eduardo Apolinario <[email protected]>
I confirmed that the command works here. We get this error if we try to start the flyteagent image:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3008 +/- ##
===========================================
- Coverage 51.08% 35.95% -15.13%
===========================================
Files 201 201
Lines 21231 21168 -63
Branches 2731 2728 -3
===========================================
- Hits 10846 7612 -3234
- Misses 9787 13448 +3661
+ Partials 598 108 -490 ☔ View full report in Codecov by Sentry. |
* Install all flyteagent image dependencies in a single command Signed-off-by: Eduardo Apolinario <[email protected]> * test - Can I run docker commands in gh workflows? Signed-off-by: Eduardo Apolinario <[email protected]> * Remove `-it` flag from `docker run` Signed-off-by: Eduardo Apolinario <[email protected]> * Remove quick test after confirming that running `docker run --rm ghcr.io/flyteorg/flyteagent:1.14.0 pyflyte serve agent --port 8000 --timeout 1` in a gh workflow works Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Why are the changes needed?
We're installing potentially incompatible grpcio dependencies in the flyetagent image.
What changes were proposed in this pull request?
Installs all dependencies in a single invocation of
uv pip install
in the flyetagent image. We also add a test at publish-time to confirm that agents can start.How was this patch tested?
Local builds.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link