This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Add Pending State and State Message in Webapi Agent #399
Closed
Future-Outlier
wants to merge
13
commits into
flyteorg:master
from
Future-Outlier:pending-state-in-agent
Closed
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d76bd9c
Add Pending State in Webapi Agent
ec85912
change return core state
763eaa7
add Status Test
79975b2
lint
5361008
refactor
503d1be
change PENDING return function PhaseInfoQueuedWithTaskInfo
fa36634
change phase queue to phase intializing
d0c1602
Merge branch 'master' of https://github.com/Future-Outlier/flyteplugi…
6b69092
Add Get Message in Agent
6835580
Add log on flyte console!
409b2b9
Add Running Message on console
9e709db
Merge branch 'master' of https://github.com/Future-Outlier/flyteplugi…
90cff0b
use reason on the log
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the message. This message does not convey any information to the user. Can the agent send this message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kumare3
flyteplugins/go/tasks/pluginmachinery/core/phase.go
Lines 220 to 226 in 503d1be
Is this solution suitable?