Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add the Slurm agent example usage #1781

Merged

Conversation

JiangJiaWei1103
Copy link
Contributor

@JiangJiaWei1103 JiangJiaWei1103 commented Feb 22, 2025

We propose to add this example to demonstrate how to use SlurmFunctionTask of the Slurm agent.

Docs link

Related PRs

@JiangJiaWei1103 JiangJiaWei1103 changed the title [Docs] Add the Slurm agent fn task example usage [WIP] [Docs] Add the Slurm agent fn task example usage Feb 22, 2025
@JiangJiaWei1103 JiangJiaWei1103 changed the title [WIP] [Docs] Add the Slurm agent fn task example usage [WIP] [Docs] Add the Slurm agent example usage Mar 10, 2025
@JiangJiaWei1103 JiangJiaWei1103 changed the title [WIP] [Docs] Add the Slurm agent example usage [Docs] Add the Slurm agent example usage Mar 11, 2025
@JiangJiaWei1103 JiangJiaWei1103 marked this pull request as ready for review March 11, 2025 15:55
Signed-off-by: JiangJiaWei1103 <[email protected]>
@JiangJiaWei1103
Copy link
Contributor Author

JiangJiaWei1103 commented Mar 15, 2025

For agent local test, executing the DL training workflow produces the following result on the Flyte client’s local machine:

Screenshot 2025-03-15 at 12 32 00 PM

Signed-off-by: Future-Outlier <[email protected]>
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help me?

  1. update README.md
  2. put training example here
  3. use make fmt to fix the lint error

@JiangJiaWei1103
Copy link
Contributor Author

Can you help me?

  1. update README.md
  2. put training example here
  3. use make fmt to fix the lint error

The training example has been added, and the lint error has been resolved. I’ll complete the README.md tomorrow.

Follow-up

Fix train and run_infer tasks to test GPU usage. I think we've not finished this part as the CUDA device isn't used here, right?

JiangJiaWei1103 and others added 7 commits March 19, 2025 21:00
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier
Copy link
Member

Can you help me?

  1. update README.md
  2. put training example here
  3. use make fmt to fix the lint error

The training example has been added, and the lint error has been resolved. I’ll complete the README.md tomorrow.

Follow-up

Fix train and run_infer tasks to test GPU usage. I think we've not finished this part as the CUDA device isn't used here, right?

the CUDA is used there, I've done some configuration in the slurm cluster.

@Future-Outlier
Copy link
Member

Can you help me?

  1. update README.md
  2. put training example here
  3. use make fmt to fix the lint error

The training example has been added, and the lint error has been resolved. I’ll complete the README.md tomorrow.

Follow-up

Fix train and run_infer tasks to test GPU usage. I think we've not finished this part as the CUDA device isn't used here, right?

not sure why the register CI fails, can you help me deep dive into it?

@JiangJiaWei1103
Copy link
Contributor Author

No problem, I'll look into this issue tmr!

@Future-Outlier Future-Outlier merged commit c9b2c44 into flyteorg:master Mar 27, 2025
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants