Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add architecture diagram for FlytePropeller plugins #34

Merged
merged 6 commits into from
Jan 26, 2024
Merged

docs: add architecture diagram for FlytePropeller plugins #34

merged 6 commits into from
Jan 26, 2024

Conversation

jasonlai1218
Copy link
Contributor

@jasonlai1218 jasonlai1218 commented Jan 2, 2024 •
edited
Loading

  • Add FlytePropeller plugins architecture image file

flyteorg/flyte#4661 depends on this

@jasonlai1218
docs: add architecture diagram for FlytePropeller plugins
9b5b019 
- Add new image file: `flytepropeller_plugins_architecture.png`

Signed-off-by: jason.lai <[email protected]>
@jasonlai1218
docs: update architecture diagram
44077c1 
- The image file `flytepropeller_plugins_architecture.png` was modified

Signed-off-by: jason.lai <[email protected]>
@jasonlai1218 jasonlai1218 mentioned this pull request Jan 2, 2024
Merged
3 tasks
@Future-Outlier
Copy link
Member

don't merge this PR, I am discussing with @jasonlai1218
We will change some part of it.

@Future-Outlier
Copy link
Member

Type of handlers.
image

@jasonlai1218 jasonlai1218 marked this pull request as draft January 3, 2024 03:26
@jasonlai1218
docs: update architecture diagram
bd165eb 
- The `flytepropeller_plugins_architecture.png` file was modified

Signed-off-by: jason.lai <[email protected]>
@jasonlai1218
docs: refactor architecture diagram
554bdfb 
- The `flytepropeller_plugins_architecture.png` file was modified.

Signed-off-by: jason.lai <[email protected]>
Future-Outlier
Future-Outlier approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonlai1218
docs: update the architecture diagram
b124819 
- The `flytepropeller_plugins_architecture.png` file was modified.

Signed-off-by: jason.lai <[email protected]>
@jasonlai1218 jasonlai1218 marked this pull request as ready for review January 15, 2024 15:40
@jasonlai1218 jasonlai1218 marked this pull request as draft January 15, 2024 15:43
Future-Outlier
Future-Outlier approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonlai1218 jasonlai1218 marked this pull request as ready for review January 21, 2024 06:26
@hamersaw
Copy link

Is the purpose of this graphic (and subsequent docs) to explain that webAPI plugins call an external service, the PodPlugin creates a k8s Pod, and other plugins create k8s resource that are then executed by k8s operator deployments? IMO much of this information is duplicated from the other graphic on this page - I'm wondering if we can present more succinctly.

@Future-Outlier
Copy link
Member

Is the purpose of this graphic (and subsequent docs) to explain that webAPI plugins call an external service, the PodPlugin creates a k8s Pod, and other plugins create k8s resource that are then executed by k8s operator deployments? IMO much of this information is duplicated from the other graphic on this page - I'm wondering if we can present more succinctly.

Hi, thanks for your review, do you think this one is more succinctly?
image

@jasonlai1218
docs: update architecture diagram
2c022b3 
- The `flytepropeller_plugins_architecture.png` file has been modified.

Signed-off-by: jason.lai <[email protected]>
@jasonlai1218
Copy link
Contributor Author

@hamersaw @Future-Outlier
I updated the picture to make it more succinct.

Future-Outlier
Future-Outlier approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @pingsutw

@pingsutw pingsutw merged commit 743dbd7 into flyteorg:main Jan 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Future-Outlier Future-Outlier Future-Outlier approved these changes

@pingsutw pingsutw pingsutw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasonlai1218 @Future-Outlier @hamersaw @pingsutw