Patch for PR of OS min/max versions #527
Conversation
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
install/policies/mdm.php
Outdated
| @@ -43,7 +43,7 @@ | |||
| 'type_data' => '', | |||
| 'unicity' => 1, | |||
| 'plugin_flyvemdm_policycategories_id' => $category, | |||
| 'comment' => __('Use TLS.', 'flyvemdm'), | |||
| 'comment' => __('Use TLS', 'flyvemdm').'.', | |||
There was a problem hiding this comment.
put the dot in the localizable string
There was a problem hiding this comment.
Why? the dot is at the end and we could use the same translation of the upper line or do you really want to have to translate two string just for only one dot?
There was a problem hiding this comment.
Maybe in some languages the punctuation may be very different to latin languages. We cannot do assumption about locales.
Moreover this policy willl change its name see #494 We wil need to improve comment and probably use longer text than only copying the name.
install/upgrade/update_to_dev.php
Outdated
| } | ||
| if ($DB->fieldExists($table, 'is_apple_policy')) { | ||
| $migration->dropField($table, 'is_apple_policy'); | ||
| } |
There was a problem hiding this comment.
Migration::dropField() already checks if the field exists before actually dropping it. This change is useless
ajsb85
changed the title
DIOHz0r
force-pushed
the
hotfix/os_min_max_versions
branch
from
0bfc786
to
b719ae0
Compare
|
Hi, @DIOHz0r |
DIOHz0r
force-pushed
the
hotfix/os_min_max_versions
branch
from
b719ae0
to
10fd9bb
Compare
|
Fixing issues that complement this PR and making several tests in the server I think I found the solution but I need to test it some more One of the main issues was that the DB was not being updated properly, the values of the os versions were not being added when running cli_install.php |
|
Indeed. I'll point to you the code that you need to update. |
|
@Naylin15 have a look into the PluginFlyvemdmInstaller::createPolicies() https://github.com/flyve-mdm/glpi-plugin/blob/develop/install/installer.class.php#L323 This method is in charge of creating / updating the policies in the database. You need to modify it to take into account the new columns you introduced. Once done, the update process should run as you expected. |
DIOHz0r
changed the title
install/policies/mdm.php
Outdated
| @@ -43,7 +43,7 @@ | |||
| 'type_data' => '', | |||
| 'unicity' => 1, | |||
| 'plugin_flyvemdm_policycategories_id' => $category, | |||
| 'comment' => __('Use TLS.', 'flyvemdm'), | |||
| 'comment' => __('Use TLS', 'flyvemdm').'.', | |||
There was a problem hiding this comment.
Maybe in some languages the punctuation may be very different to latin languages. We cannot do assumption about locales.
Moreover this policy willl change its name see #494 We wil need to improve comment and probably use longer text than only copying the name.
Signed-off-by: Domingo Oropeza <[email protected]>
fix value type Signed-off-by: Naylin Medina <[email protected]>
Signed-off-by: Naylin Medina <[email protected]>
DIOHz0r
force-pushed
the
hotfix/os_min_max_versions
branch
from
4064bd8
to
4d732cf
Compare
Changes description
Add missed code for the PR #509