Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

Migrate gh-pages to CircleCI #116

Merged
merged 7 commits into from
Aug 11, 2018
Merged

Migrate gh-pages to CircleCI #116

merged 7 commits into from
Aug 11, 2018

Conversation

Naylin15
Copy link
Contributor

@Naylin15 Naylin15 commented Aug 7, 2018

Changes description

Migrate gh-pages tests to circleci
Normalize development section

Checklist

Please check if your PR fulfills the following specifications:

  • Tests for the changes have been added
  • Docs have been added/updated

Estimated time

Assignee 🍅
@Naylin15 2

References

Closes #115
Closes #114
Related #N/A
Depends on #N/A

@Naylin15 Naylin15 added this to the 1.3 milestone Aug 7, 2018
@Naylin15 Naylin15 self-assigned this Aug 7, 2018
Copy link
Contributor

@ajsb85 ajsb85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Naylin15
This branch has conflicts that must be resolved.
And your tests failed on CircleCI.

@ajsb85 ajsb85 changed the title Migrate gh-pages to CircleCI WIP: Migrate gh-pages to CircleCI Aug 8, 2018
@ajsb85 ajsb85 changed the title WIP: Migrate gh-pages to CircleCI WIP Migrate gh-pages to CircleCI Aug 8, 2018
@Naylin15
Copy link
Contributor Author

Naylin15 commented Aug 9, 2018

Fixing the conflicts

The test will fail since the documentation is being generated with an erroneous link, I opened this issue #117 regarding this

remove travis.yml file
add circle config to linter

Signed-off-by: Naylin Medina <[email protected]>
Signed-off-by: Naylin Medina <[email protected]>
@Naylin15 Naylin15 changed the title WIP Migrate gh-pages to CircleCI Migrate gh-pages to CircleCI Aug 9, 2018
@Naylin15 Naylin15 requested a review from ajsb85 August 9, 2018 13:58
@ajsb85 ajsb85 merged commit e985ae0 into gh-pages Aug 11, 2018
@ajsb85 ajsb85 deleted the feature/migrate-ci branch August 11, 2018 20:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants