Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache toggle api #3

Merged
merged 4 commits into from
Jan 23, 2024
Merged

fix: cache toggle api #3

merged 4 commits into from
Jan 23, 2024

Conversation

alaminfirdows
Copy link
Member

This update ensures that changes made in FlyWP's Page Caching settings now correctly show up in the WordPress admin panel. The PR addresses the issue with the cache toggle API triggered from the FlyWP application.

Ref: https://github.com/flywp/flywp-app/issues/144

@tareq1988
Copy link
Contributor

Why are you changing the POST to GET? An API shouldn't perform this kind of things via a GET request.

Also, as I had told on the chat, the settings key is flywp_fastcgi_cache. So having a enable and disable option is good enough. We don't need to change it to fastcgi.

@alaminfirdows
Copy link
Member Author

Why are you changing the POST to GET? An API shouldn't perform this kind of things via a GET request.

Also, as I had told on the chat, the settings key is flywp_fastcgi_cache. So having a enable and disable option is good enough. We don't need to change it to fastcgi.

I followed the application's API call and replaced it with the GET method. Otherwise, we would have to change both ends. I also prefer to keep it as the POST method.

@tareq1988 tareq1988 merged commit 62f1f9f into develop Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants