Merge changes from jwst-kpi xara version #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLEAR is generated with `WebbPrimaryAperture` (with mag=10 for consistency with CLEARP) instead of `MASKCLEAR.fits` and CLEARP now has consistent alignment between primary and secondary. Thanks to Rachel Cooper (@rcooper295) for the scripts used to genreate these masks.
Update CLEAR and CLEARP masks FITS files
Formatting and file I/O updates
Add more control over plotting
Add option to crop NIRISS data
Include pupil models even if not locally installed
Add standard Python `.gitignore`
Remove JWST Pipeline code
To avoid introducing changes that are not necessary to new functionality
Remove parenthesis and do not compare booleans, following PEP 8
Remove parenthesis and do not compare booleans, following PEP 8
np.float -> float
Document changes to xara core for calwebb functionality
Make integer-pixel recentering independent of sgmask
Merge Changes from main xara branch
Before, hexagon was imported from opticstools. Now copied into xara for convenience (easier installation, no additional dependency).
Python shows a warning otherwise (and it's less safe)
Reapply old changes that got overwritten
Xara has no types sets and pyright is common tool for vscode, does not hurt to keep this here I guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges changes from kammerje/xara, which was used as the JWST KPI pipeline before the pipeline had its own repo (kammerje/jwst-kpi). Now most changes in kammerje/xara are generic and could be merged here.
I have not done a careful diff check, just applied a merge from Jens' version to this one. Marking as draft for this reason and will update after looking at the diffs.
I'm also waiting for kammerje#22 to be merged, bringing support for the KPFITS format.
This fixes #5 and kammerje#21.