-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate report grid memory consumption #1020
Open
ykempf
wants to merge
21
commits into
fmihpc:dev
Choose a base branch
from
ykempf:activate_report_grid_memory_consumption
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Activate report grid memory consumption #1020
ykempf
wants to merge
21
commits into
fmihpc:dev
from
ykempf:activate_report_grid_memory_consumption
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have this function, why not use it?
Suggestion from Markus: implement a similar memory report functionality for fsgrid. Not today. |
Example output:
So let's discuss if we want more info (value and rank of local vs. remote cells' min and max capacity?), and in what format/ordering. And also, this should list explicitly that we're talking of the spatial cells here, especially if/when we extend this to also report fsgrid memory usage. |
…w places in grid.cpp.
… grid report function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for laughs? How long has this not been used? Not like I just spent a number of weeks looking into memory consumption...........