SysBoundary communicate VDFs only in smaller neighborhood #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a subset of #1048 and will need more features/changes in any case. |
|
So this is still not doing fluffy copy, which is used in copysphere, correctly. Will be fixed soon. I came back to this branch/PR as I am not taking in everything that was pushed to #1048. Mainly, I let it create (local) VDFs and compute their moments when needed, instead of adding spaghetti to save on that. What's expensive ar second-neighbour VDFs and their communication, not the actual local L2 VDFs. |
This reverts commit a646d4b.
ykempf
commented
Feb 24, 2025
ykempf
commented
Feb 24, 2025
sysboundary/ionosphere.cpp
Outdated
| @@ -3474,6 +3474,20 @@ namespace SBC { | |||
|
|
|||
| calculateCellMoments(&templateCell,true,false,true); | |||
|
|
|||
| for (uint popID=0; popID<getObjectWrapper().particleSpecies.size(); ++popID) { | |||
| @@ -395,6 +394,10 @@ namespace SBC { | |||
| const uint popID, | |||
| const bool calculate_V_moments | |||
| ) override; | |||
| virtual void setupL2OutflowAtRestart( | |||
There was a problem hiding this comment.
Instead of having these warnings in all the "wrong" boundaries, I think it should exist in the base class as a warning and be just missing from all the others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.