Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bin pencils #1096

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Bin pencils #1096

wants to merge 5 commits into from

Conversation

lkotipal
Copy link
Contributor

Attempt binning pencils to enable more threaded translation without race conditions

@lkotipal lkotipal marked this pull request as ready for review February 25, 2025 22:53
@lkotipal
Copy link
Contributor Author

algorithms-Spatial-space-time algorithms-Spatial-space-cells

Performance results from 20s of samples/Magnetosphere3D:

control
386.83680216471356 +- 0.6757976138800245
control cells/second compared to control: 1.0
control / control: KstestResult(statistic=0.0, pvalue=1.0, statistic_location=384343.7957763672, statistic_sign=1)

binned
403.1496047973633 +- 1.1022723703182713
binned cells/second compared to control: 1.0421697277543511
control / binned: KstestResult(statistic=1.0, pvalue=0.0021645021645021645, statistic_location=389477.9968261719, statistic_sign=1)

ykempf
ykempf reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@ykempf ykempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this also has a truncated ionsosphere report (fixed elsewhere) and a non-matching grid that should be flagged RED!

Any way this can help in sorting translation summation at AMR X task interfaces to get better reproducibility/less diffs in testpackage flags?

@lkotipal
Copy link
Contributor Author

Not sure. The order of pencils is deterministic, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykempf ykempf ykempf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkotipal @ykempf