Cudafield #804
Draft
Cudafield #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-L1369 DRO.cpp function messed up
-Compiles but produces incorrect results
-Not working properly (cudaMemcpy error)
-This fixed the initial reduction values -Likely a bug in cuda_moments.cpp (moments_r)
markusbattarbee
requested changes
Aug 24, 2023
| @@ -31,7 +31,7 @@ | |||
| //FieldFunction should be initialized | |||
| void setBackgroundField( | |||
| const FieldFunction& bgFunction, | |||
| FsGrid< std::array<Real, fsgrids::bgbfield::N_BGB>, FS_STENCIL_WIDTH> & BgBGrid, | |||
| FsGrid< Real, fsgrids::bgbfield::N_BGB, FS_STENCIL_WIDTH> & BgBGrid, | |||
There was a problem hiding this comment.
Are you sure we can't maintain range checks in FSgrid on GPUs? We do have range checks on GPUs in splitvector.
| @@ -25,6 +25,8 @@ | |||
| #include <iostream> | |||
| #include <limits> | |||
| #include <array> | |||
| #include <memory> | |||
There was a problem hiding this comment.
Let's not include development benchmarking stuff in the actual PR (Also for the clock() calls and printfs below)
kstppd
reviewed
Aug 24, 2023
| FsGrid<T, TDim, N> *ptr; | ||
| FsGrid<T, TDim, N> *h_ptr; | ||
| FsGrid<T, TDim, N> *d_ptr; | ||
| uint dataSize; |
There was a problem hiding this comment.
Should probably consider using 64-bit here to future proof it .
… mesh parameters struct, moving a few other things around
Cudafield revertparams
Fixed some compiler warnings and removed use of NDEBUG in favour of D…
…d_fixes Cudafield optimizations and fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.