Make the base directory for requests configurable #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `/requests` path was hardcoded in a bunch of places making it difficult to install fmperf in a running container where you don't have root access to `mkdir /create`. I've added an environment variable that defaults to "" so that all paths become local. If the path is not empty the code makes sure that there is an "/" at the end to concatenate the paths. To prevent breaking existing scripts, in the Dockerfile the environment variable is set to `/requests` Signed-off-by: Max de Bayser <[email protected]>
|
cc: @tdoublep |
Signed-off-by: Max de Bayser <[email protected]>
tdoublep
reviewed
Sep 17, 2024
Signed-off-by: Max de Bayser <[email protected]>
Signed-off-by: Max de Bayser <[email protected]>
Signed-off-by: Max de Bayser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/requestspath was hardcoded in a bunch of places making it difficult to install fmperf in a running container where you don't have root access tomkdir /create.I've added an environment variable that defaults to "" so that all paths become local. If the path is not empty the code makes sure that there is an "/" at the end to concatenate the paths.
To prevent breaking existing scripts, in the Dockerfile the environment variable is set to
/requests