Skip to content

Add browser.device.desktop? #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add browser.device.desktop? #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c8fe43
Add browser.device.desktop?
toshimaru Dec 10, 2020
4d907d7
test: refute device.desktop?
toshimaru Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ browser.device.switch?
browser.device.xbox?
browser.device.xbox_360?
browser.device.xbox_one?
browser.device.desktop?

# Get platform info
browser.platform
Expand Down
4 changes: 4 additions & 0 deletions lib/browser/device.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ def mobile?
detect_mobile? && !tablet?
end

def desktop?
!detect_mobile? && !tablet?
end

def ipad?
id == :ipad
end
Expand Down
2 changes: 2 additions & 0 deletions test/unit/device_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ def id
device = Browser::Device.new(Browser[key])
assert device.mobile?
refute device.tablet?
refute device.desktop?
end
end

Expand All @@ -236,6 +237,7 @@ def id
device = Browser::Device.new(Browser[key])
assert device.tablet?
refute device.mobile?
refute device.desktop?
end
end

Expand Down