Skip to content
This repository has been archived by the owner on Feb 9, 2020. It is now read-only.

Prevent long password denial of service #28

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

cianmce
Copy link

@cianmce cianmce commented Sep 30, 2018

As described here #27, this gem is vulnerable to DOS attacks

This PR:

  1. Adds a limit for both usernames and passwords. A password length of 1,000 is recommended by OWASP

A limit of 1000 characters is sufficient to let the user choose a very big password without impacting the system.
https://www.owasp.org/index.php/Password_Storage_Cheat_Sheet#Input_password_size

  1. Adds JS/Ruby tests that the password/username is being truncated
  2. Removes unused $BREAKPOINT variable from ruby tests
  3. Removes unneeded JS comment // assert @strength.invalid?

@cianmce
Copy link
Author

cianmce commented Oct 20, 2018

@fnando does this seem like a reasonable solution to this security vulnerability?

@cianmce
Copy link
Author

cianmce commented Oct 20, 2018

@fnando any reason for deleting the version file? This is causing CI to fail. Would you rather I increment it differently?

@cianmce
Copy link
Author

cianmce commented Jan 18, 2019

@fnando can this be merged and released?

@cianmcelhinney
Copy link

@fnando bump
Can this be merged and released?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants