Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixes #98 #99

Merged
merged 2 commits into from
Feb 4, 2025
Merged

This fixes #98 #99

merged 2 commits into from
Feb 4, 2025

Conversation

KameiB
Copy link

@KameiB KameiB commented Dec 15, 2024

Turns out TileEntityFurnace and TileEntityBrewingStand don't extend TileEntityLockableLoot, but TileEntityLockable.

But since TileEntityLockable doesn't have the method setInventorySlotContents, I had to manually check if tileEntity is an instance of TileEntityFurnace or TileEntityBrewingStand and call setInventorySlotContents accordingly.

Moonshine correctly generated in B-Team's Hideout, and coal was found inside the Bedroom's Furnace 😄

If you know a more elegant way to implement this fix, feel free to do so and don't merge this PR.

We're getting closer and closer to perfection! 🎉

Copy link
Owner

@fnar fnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fnar fnar merged commit 23de9da into fnar:master Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants