Skip to content

Commit

Permalink
Merge pull request #2 from dkarrasch/patch-1
Browse files Browse the repository at this point in the history
Matrixify Q before comparison
  • Loading branch information
tobydriscoll authored Aug 4, 2022
2 parents 1abe49f + 2f2ffb1 commit 5590e18
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ end
@test FNC.lsqrfact(A,b) A\b
Q,R = qr(A)
QQ,RR = FNC.qrfact(A)
@test Q QQ
@test Matrix(Q) QQ
@test R RR[1:3,:]
end

Expand Down Expand Up @@ -258,4 +258,4 @@ end
u = FNC.elliptic(pde,g,30,[0,2.5],24,[0,1]);
@test u(1.25,0.5) 1.7236921361 rtol = 1e-6
@test u(1,0) 1 rtol = 1e-6
end
end

1 comment on commit 5590e18

@dkarrasch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please release this fix so that nanosoldier doesn't bump into the fixed issue?

Please sign in to comment.