Implements Stripe Refund functionality and wires the button #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrate Stripe refunds to admin ticket requests view
kigster
requested changes
May 24, 2024
app/models/payment.rb
Outdated
| self.status = STATUS_REFUNDED | ||
| Rails.logger.info { "refund_payment success stripe_refund_id [#{stripe_refund_id}] status [#{status}]" } | ||
| log_refund(refund) | ||
| save |
There was a problem hiding this comment.
Might want to call save! which raises exception if it can't be saved.
Then you could add additional rescue:
rescue StandardError => e
Rails.logger.error("#{e.class.name} ERROR during a refund: #{e.message.colorize(:red)}")
app/models/ticket_request.rb
Outdated
| Rails.logger.info { "ticket_request [#{id}] payment [#{payment.id}] refunding [#{payment.stripe_payment_id}]" } | ||
| if payment.refund_payment | ||
| mark_refunded | ||
| true |
There was a problem hiding this comment.
Remove the true — we should return the result of mark_refunded which would be true if the update succeeds. See above.
app/models/ticket_request.rb
Outdated
| mark_refunded | ||
| true | ||
| else | ||
| Rails.logger.error { "ticket_request failed to refund [#{payment.stripe_payment_id}]" } |
There was a problem hiding this comment.
Please add the cause to the logger, by adding errors&.error_messages&.join('; ').
kigster
changed the title
kigster
added
review-requires-updates
kigster
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Refund button to events ticket requests page for all payments page
Uses Stripe Refund API