-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
232 role as event option #235
Conversation
add event model param for require_role add event form checkbox for require role add ticket request check for require role
font-titillium has been removed from homebrew github is colliding with installed github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should already have a ticket request submission spec.
I would like to see this field being sent as both false and true and verify that it saves the proper value into the DB.
I worry that the checkbox will by the default be unchecked, and that submitting a form with it unchecked would save it as a true value (which is the default).
Perhaps it's not doing that, but adding this to the spec would ensure that for certain.
Align if to just role selection Add if check to request show
@kigster the events controller spec now has a test to ensure that the require role is true by default. |
@kigster ready for re-review |
Adding event option to make role collection optional