A slew of performance related changes. #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding Bullet gem, enabled in development although not sure I am seeing the output I expected. * Updating Makefile to migrate with data * Updating #set_event to log a warning when SLUG does not match the event_id parameter. Eventually we should throw an error. * memoizing a bunch of computations on the TicketRequest model * Extracting event row on the All Events page into a partial * Rendering the partials as a collection, with cached: true * Adding `touch: true` to inverse of `TicketRequest.belongs_to(Event)` so that the cache is auto-refreshed * Adding memcached based caching in dev/production using localhost memcached. Enable in dev by running `rake cache:dev` * Adding a test on the now memoized method `#active_addon_sum_quantity_by_category` to confirm its validity.
beingmattlevy
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Bullet gem, enabled in development although not sure I am seeing the output I expected.
Updating Makefile to migrate with data
Updating #set_event to log a warning when SLUG does not match the event_id parameter. Eventually we should throw an error.
memoizing a bunch of computations on the TicketRequest model
Extracting event row on the All Events page into a partial
Rendering the partials as a collection, with cached: true
Adding
touch: trueto inverse ofTicketRequest.belongs_to(Event)so that the cache is auto-refreshedAdding memcached based caching in dev/production using localhost memcached. Enable in dev by running
rake cache:devAdding a test on the now memoized method
#active_addon_sum_quantity_by_categoryto confirm its validity.