Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add csv and logger gems to remove warnings #308

Merged
merged 8 commits into from
Sep 23, 2024
Merged

Add csv and logger gems to remove warnings #308

merged 8 commits into from
Sep 23, 2024

Conversation

kigster
Copy link
Collaborator

@kigster kigster commented Sep 23, 2024

Fixing two warnings:

warning: /Users/kig/.rbenv/versions/3.3.5/lib/ruby/3.3.0/logger.rb 
was loaded from the standard library, but will no longer be part 
of the default gems starting from Ruby 3.5.0.

@kigster kigster self-assigned this Sep 23, 2024
@kigster kigster added the upgrades Any gem or Ruby upgrade label Sep 23, 2024
@kigster kigster force-pushed the kig/remove-warnings branch from 9e893cf to b2d3405 Compare September 23, 2024 18:40
@kigster kigster force-pushed the kig/remove-warnings branch 2 times, most recently from 20aa43f to daafabd Compare September 23, 2024 19:02
@kigster kigster force-pushed the kig/remove-warnings branch from daafabd to e23bbee Compare September 23, 2024 19:04
kigster
kigster commented Sep 23, 2024
View reviewed changes
spec/spec_helper.rb
@@ -1,5 +1,10 @@
# frozen_string_literal: true

ENV['RAILS_ENV'] = 'test'

$stdout.sync = true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so that if RSpec hangs on Github Action, we see which one.

kigster
kigster commented Sep 23, 2024
View reviewed changes
spec/spec_helper.rb
@@ -22,4 +25,11 @@
config.expect_with(:rspec) do |c|
c.syntax = %i[should expect]
end

config.around do |example|
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to have this in spec_helper.rb and apply to all specs. Even 10 seconds is extremely generous.

kigster
kigster commented Sep 23, 2024
View reviewed changes
spec/spec_helper.rb

config.around do |example|
# 10 seconds should be more than enough for ANY spec
Timeout.timeout(ENV.fetch('RSPEC_TIMEOUT', 10).to_i) do
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow eg CI to override the timeout if necessary.

@kigster kigster merged commit ed4f988 into main Sep 23, 2024
3 checks passed
@kigster kigster deleted the kig/remove-warnings branch September 23, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beingmattlevy beingmattlevy Awaiting requested review from beingmattlevy

Assignees

@kigster kigster

Labels
upgrades Any gem or Ruby upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kigster