VCR integration

README.adoc

@@ -208,7 +208,54 @@ Here is an example:
 
 image:docs/make-boot.png["Booting with Make"]
 
-=== Tooling
+=== API Testing
+
+HTTP API Specs use the VCR Gem to mock calls to external APIs using a record and replay model.
+https://github.com/vcr/vcr
+
+Usage: https://benoittgt.github.io/vcr/#/
+
+Cassettes are stored in spec/fixtures/vcr_cassettes
+If an API changes due to version, response, etc... you will need to rebuild cassettes for those specs.
+Delete the directory and/or files for the specs that have changed.
+It is ok to delete all cassettes and regenerate everything.
+This can be done in your local development environment.
+
+VCR is configured in spec/spec_helper.rb
+
+You must filter any API keys before you check in cassettes to prevent keys in GitHub
+https://benoittgt.github.io/vcr/#/configuration/filter_sensitive_data
+
+To enable vcr recording on a given spec, add a vcr hook to the spec as follows
+
+    it 'does not change payment intent', :vcr do
+        expect { payment_intent }.not_to(change(payment, :payment_intent))
+    end
+
+To turn off VCR HTTP request interception for a given spec or block, add
+
+    VCR.turned_off do
+        make_request "In VCR.turned_off block"
+    end
+
+    make_request "Outside of VCR.turned_off block"
+
+    VCR.turn_off!
+    make_request "After calling VCR.turn_off!"
+
+    VCR.turned_on do
+        make_request "In VCR.turned_on block"
+    end
+
+    VCR.turn_on!
+    make_request "After calling VCR.turn_on!"
+
+https://benoittgt.github.io/vcr/#/cassettes/no_cassette
+
+
+To turn off VCR by default for http requests see:
+https://benoittgt.github.io/vcr/#/configuration/allow_http_connections_when_no_cassette
+
 
 ==== Adding Site Admin
 

app/controllers/payments_controller.rb

@@ -103,7 +103,7 @@ def sent
   private
 
   def mark_payment_completed
-    Payment.transaction do
+    begin
       @payment.request_completed
       flash.now[:notice] = 'Payment has been received and marked as completed.'
     rescue StandardError => e

app/models/payment.rb

@@ -222,17 +222,17 @@ def mark_received
     status_received!
   end
 
-  # In transaction,
   # mark payment received and ticket request completed
   # Send off PaymentMailer for payment received
   def request_completed
-    mark_received
-    ticket_request.mark_complete
+    Payment.transaction do
+      # set payment and ticket request status
+      mark_received
+      ticket_request.mark_complete
 
-    # Deliver the email asynchronously
-    PaymentMailer.payment_received(self).deliver_later
-
-    self.reload
+      # Deliver the email asynchronously
+      PaymentMailer.payment_received(self).deliver_later
+    end
   end
 
   private