Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upgrade] Rails 4.2 ➜ 7.1 | Ruby 2.5.9 ➜ Ruby 3.2.3 | Upgrade #70

Closed
wants to merge 31 commits into from
Closed

[Upgrade] Rails 4.2 ➜ 7.1 | Ruby 2.5.9 ➜ Ruby 3.2.3 | Upgrade #70

wants to merge 31 commits into from

Conversation

kigster
Copy link
Collaborator

@kigster kigster commented Apr 9, 2024 •
edited
Loading

Description

This PR contains the body of work that upgrades the TicketBooth application from Rails 4 to Rails 7.1 and the most recent Ruby Interpreter.

  • Rails 4.2 ➜ Rails 7.1 [In Progress]
  • Ruby 2.5.9 ➜ Ruby 3.2.3 [In Progress]
  • PostgreSQL 9 ➜ PostgreSQL v16

Related Issue

#58

Status

Current Status:

  • Model Specs
  • Lib specs
  • Controller Specs
  • Classes Specs
  • Mailer Specs

Remaining

TicketRequestController#create action is currently failing.

kigster and others added 30 commits March 11, 2024 11:07
@kigster
Create rubyonrails.yml (#57)
70b2839
@kigster
Raills 6.0.6.1 & Ruby 3.2.2 (#56)
38d4774 
* Create rubyonrails.yml

* [WIP] Rails 6.0.2 & Ruby 3.2.3

* Fixing a bunch of failing specs

* Fix event_admin specs
@kigster
WIP [ALT]: Rails 4.2 → Rails 6, Ruby 3.2.3 Upgrade (direct to main) (#65
44f7801 
)
@kigster
WIP: rails 6, ruby 3.2
041609e
@kigster
Simplify CI flow
6b30327
@kigster
WIP: fixing more specs and models
aa8208d 
 * removing Sham
 * adding Faker gem
 * switching from custom made make! to build() using FactoryBot
 * fixing submissions link generator
@kigster
Add postgresql-client-16
3da49ac
@kigster
Run rspec in progress mode without backtrace
909d6c6
@kigster
Updating README - hoping to sign with gpg key
f8679ca
@kigster
Sign with GPG goddamit
0a78299
@kigster
Fix the SimpleCSS link
593db08
@kigster
Fixing submission link generation instructions
b3463be
@kigster
Fix site admin specs
dc0cce7
@kigster
Fix payment mailer specs, add eald spec
4a9588a
@kigster
Update site_admin_spec.rb
cdd0077
@kigster
Only Controller tests are remaining
90212a2
@kigster
Switch to type: :controller, 6/174 specs remaining
c5dc38a
@kigster
Deleting redundant FactoryBot Helper
a7c24cc
@kigster
Fix rubocop
7fea72b
@kigster
Adding db:seed task
bf691df
@kigster
Adding a two more tests to EventsController
71eb7dc
@kigster
Fix observer/ventable specs
2233b0e
@kigster
Just 5 specs left to fix
071ac34
@kigster
Fixing rubocop
8848fb9
@kigster
Fixing asset pipeline
8f4db64
@kigster
Fix link colors
3f19a12
@kigster
Fix rubocop
ba274af
@kigster
Updating README & bin/boot-up
ada5568
@kigster
Fixing rubocop
3d1e77f
@kigster
Fix rspec warning
b5ee39c
@kigster kigster requested a review from a team as a code owner April 9, 2024 17:07
@kigster kigster self-assigned this Apr 9, 2024
@kigster kigster mentioned this pull request Apr 9, 2024
Closed
@kigster kigster changed the title [Upgrade] Rails 7.1, Ruby 3.2 Upgrade [Upgrade] Rails 4.2 ➜ 7.1 | Ruby 2.5.9 ➜ Ruby 3.2.3 | Upgrade Apr 9, 2024
@kigster kigster added stale The PR is likely out of date and removed work-in-progress dependency-upgrades Dependency upgrade labels Apr 13, 2024
@kigster kigster closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kigster kigster

Labels
stale The PR is likely out of date
Projects
None yet
Milestone
M1: TicketBooth Upgrade Ready for Tes...
Development

Successfully merging this pull request may close these issues.
1 participant
@kigster