-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix user registration + auto-hide error/notice messages from the UI #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kigster
commented
Apr 21, 2024
•
edited
Loading
edited
- Fixing User Registration form
- Also show them sticky
- Also, add development SMTP Gmail settings for testing email
- Also switched back to light scheme with a slighly darker nav
* Also show them sticky * Also, add development SMTP Gmail settings for testing email * Also switched back to light scheme with a slighly darker nav
kigster
force-pushed
the
kig/autohide-error-messages
branch
from
April 21, 2024 03:32
74fa054
to
229b8e9
Compare
kigster
changed the title
Auto-hide error/notice messages from the UI
Fix user registration + auto-hide error/notice messages from the UI
Apr 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A couple non blocking comments.
beingmattlevy
approved these changes
Apr 21, 2024
kigster
commented
Apr 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated as per @beingmattlevy comments
kigster
added
ready-for-deploy
ready-for-merge
and removed
ready-for-review
ready-for-deploy
labels
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.