Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] [NP-2802] Make predicates ContextAware #4386

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

KernelDeimos
Copy link
Contributor

@KernelDeimos KernelDeimos commented Nov 28, 2020

Adding DNM because I want to test a serializable sink solution.

@google-cla google-cla bot added the cla: yes label Nov 28, 2020
@KernelDeimos KernelDeimos changed the title [NP-2802] Make predicates ContextAware [DMN] [NP-2802] Make predicates ContextAware Nov 28, 2020
@KernelDeimos KernelDeimos changed the title [DMN] [NP-2802] Make predicates ContextAware [DNM] [NP-2802] Make predicates ContextAware Nov 28, 2020
@KernelDeimos KernelDeimos changed the title [DNM] [NP-2802] Make predicates ContextAware [NP-2802] Make predicates ContextAware Nov 28, 2020
@KernelDeimos KernelDeimos changed the title [NP-2802] Make predicates ContextAware [DNM] [NP-2802] Make predicates ContextAware Nov 29, 2020
@lchanmann
Copy link
Contributor

Discussed with Eric offline to try overriding 'deepClone' instead.

@KernelDeimos
Copy link
Contributor Author

The deepClone approach gives me the system context, but to check if preconditions are met the session context is needed. There is also a security concern with predicates accessing the system context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants