Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

FOGL-3145 Remove RapidJSON from the 3rd party code and use package #1642

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

MarkRiddoch
Copy link
Contributor

No description provided.

@MarkRiddoch MarkRiddoch requested a review from pintomax August 16, 2019 11:25
pintomax
pintomax previously approved these changes Aug 16, 2019
@ashish-jabble
Copy link
Contributor

@MarkRiddoch For now I have installed rapidjson-dev dep explicitly as an interim solution on FogLAMP-PR Unit tester. Now seems like compilation issue failed with -j2 or -j4 flag. On PR tester we are using (-j2) to get result faster.

@MarkRiddoch
Copy link
Contributor Author

@MarkRiddoch For now I have installed rapidjson-dev dep explicitly as an interim solution on FogLAMP-PR Unit tester. Now seems like compilation issue failed with -j2 or -j4 flag. On PR tester we are using (-j2) to get result faster.

Looking at the result of the latest run it appears that at least one of the file is missing from the rapidjson-dev package on the PR Tester machine.

@ashish-jabble
Copy link
Contributor

ashish-jabble commented Sep 11, 2019

@MarkRiddoch On PR tester machine. Below one pakcage is already installed

$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.6 LTS
Release:	16.04
Codename:	xenial

$ sudo dpkg -l | grep rapidjson-dev
ii  rapidjson-dev                        0.12~git20141031-3                         all          fast JSON parser/generator for C++ with SAX/DOM style API

 $ find /usr/ -name rapidjson.h
/usr/include/rapidjson/rapidjson.h

$ ls /usr/include/rapidjson/
allocators.h       encodings.h        filestream.h       memorybuffer.h     prettywriter.h     stringbuffer.h     
document.h         error/             filewritestream.h  memorystream.h     rapidjson.h        writer.h           
encodedstream.h    filereadstream.h   internal/          msinttypes/        reader.h     
      

ostreamwrapper.h is missing

Let me know what else required as a prerequisite to make this compile succesfully?

@ashish-jabble
Copy link
Contributor

@MarkRiddoch Also I have tried to compile this on local environment i.e ubuntu both ub16 & ub18. It passes on ub1804 but fails on ub1604. Below are the comparison of some commands.

command Ubuntu1604 Ubuntu1804
$ make
$sudo dpkg -l grep rapidjson-dev ii rapidjson-dev 0.12~git20141031-3 all fast JSON parser/generator for C++ with SAX/DOM style API ii rapidjson-dev 1.1.0+dfsg2-3 all fast JSON parser/generator for C++ with SAX/DOM style API
$ find /usr/ -name rapidjson.h /usr/include/rapidjson/rapidjson.h /usr/include/rapidjson/rapidjson.h
$ ls /usr/include/rapidjson allocators.h encodedstream.h error filestream.h internal memorystream.h prettywriter.h reader.h writer.h document.h encodings.h filereadstream.h filewritestream.h memorybuffer.h msinttypes rapidjson.h stringbuffer.h allocators.h encodedstream.h error filewritestream.h internal memorybuffer.h msinttypes pointer.h rapidjson.h schema.h stringbuffer.h document.h encodings.h filereadstream.h fwd.h istreamwrapper.h memorystream.h ostreamwrapper.h prettywriter.h reader.h stream.h writer.h

NOTE: PR tester (CI) runs on ubuntu1604

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants