light/dark mode themed icons #659
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nges defined for light & dark
|
Not sure why the build scripts are failing on the icon resource build make: *** No rule to make target 'res/icons/dark/svg/done.svg', needed by 'qrc_icons.cpp'. Stop. |
|
I just pulled down the pull release and tried to build locally and got the
same message. If I look in res/icons/light/svg/ I see a done.svg but I
don't have one in res/icons/dark/svg/
Looks like I am missing these files in the dark folder:
baseline-stop.svg
connect.svg
disconnect.svg
done.svg
new-window.svg
…On Tue, Apr 29, 2025 at 9:41 AM Kyle Boyle ***@***.***> wrote:
*kyleboyle* left a comment (foldynl/QLog#659)
<#659 (comment)>
Not sure why the build scripts are failing on the icon resource build
make: *** No rule to make target 'res/icons/dark/svg/done.svg', needed by
'qrc_icons.cpp'. Stop.
—
Reply to this email directly, view it on GitHub
<#659 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUEEMXVLDSFLCMBSNBBNR2T236FRFAVCNFSM6AAAAAB4DDYWLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZZGE4TAMZYGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
|
|
thanks, seems git didn't handle all the renaming properly |
|
Yup that got it. Builds and looks fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
Kapture.2025-04-29.at.10.59.36.webm