Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODLOGSAML-192: Allow callback endpoint to return RTR tokens when configured #171

Merged
merged 13 commits into from
Sep 12, 2024

Conversation

steveellis
Copy link
Contributor

@steveellis steveellis commented Sep 9, 2024

https://folio-org.atlassian.net/browse/MODLOGSAML-192

  • Created this branch from latest release. Plan to merge into a new bx.x branch (to create the CSP release from) and also to master.
  • Adds new configuration property useSecureTokens.
  • Changes SamlApi route to return RTR tokens when callback:callback and useSecureTokens are present.
  • If just callback is present it will work in legacy mode.
  • If callback-with-expiry is present for callback config prop it will return RTR tokens.
  • Created more json mocks to represent the new requirement of callback AND useSecureTokens.
  • Tests are more DRY, creating a few shared methods.
  • Pulled in Julian's SimpleSamlPhpContainer class because it helped simplify IdpTest and the new IdpTestCallback. This will make merging easier and is fine since it is just tests.

Hope to get this merged by end of the week to meet the Q CSP 4 deadline.

- Remove code dup from ConfigEntryUtil
- Fix up code formatting
- Simplification of expression to detect legacy response
pom.xml Show resolved Hide resolved
@steveellis steveellis changed the base branch from master to b2.8 September 10, 2024 16:42
pom.xml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 11, 2024

Copy link
Contributor

@julianladisch julianladisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@steveellis steveellis merged commit a4445f5 into b2.8 Sep 12, 2024
7 checks passed
@steveellis steveellis deleted the MODLOGSAML-192 branch September 12, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants