-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MODLOGSAML-192: Allow callback
endpoint to return RTR tokens when configured (merge for CSP)
#171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove code dup from ConfigEntryUtil - Fix up code formatting - Simplification of expression to detect legacy response
Quality Gate passedIssues Measures |
julianladisch
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
steveellis
changed the title
MODLOGSAML-192: Allow
MODLOGSAML-192: Allow Oct 15, 2024
callback
endpoint to return RTR tokens when configuredcallback
endpoint to return RTR tokens when configured (merge for CSP)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/MODLOGSAML-192
bx.x
branch (to create the CSP release from) and also tomaster
.useSecureTokens
.SamlApi
route to return RTR tokens whencallback:callback
anduseSecureTokens
are present.callback
is present it will work in legacy mode.callback-with-expiry
is present forcallback
config prop it will return RTR tokens.callback
ANDuseSecureTokens
.SimpleSamlPhpContainer
class because it helped simplifyIdpTest
and the newIdpTestCallback
. This will make merging easier and is fine since it is just tests.Hope to get this merged by end of the week to meet the Q CSP 4 deadline.
For PR that merges these changes to master please see: #180