Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cn-browse): handle deletes/updates of call-numbers #734

Merged
merged 2 commits into from
Jan 21, 2025
Merged

feat(cn-browse): handle deletes/updates of call-numbers #734

merged 2 commits into from
Jan 21, 2025

Conversation

psmagin
Copy link
Contributor

@psmagin psmagin commented Jan 16, 2025 •
edited
Loading

Purpose

Handle deletes/updates of call-numbers

Approach

Fix delete SQL query for call-numbers to filter by item ids instead of instance ids

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://folio-org.atlassian.net/browse/MSEARCH-940

@psmagin psmagin changed the base branch from master to feature/call-number-browse-v2 January 16, 2025 13:46
@psmagin psmagin force-pushed the MSEARCH-940 branch 2 times, most recently from 5d79ab4 to fd1a502 Compare January 17, 2025 11:11
@psmagin psmagin changed the title MSEARCH-940 feat(cn-browse): handle deletes/updates of call-numbers Jan 17, 2025
@psmagin psmagin self-assigned this Jan 17, 2025
@psmagin psmagin marked this pull request as ready for review January 17, 2025 11:54
@psmagin psmagin requested a review from a team as a code owner January 17, 2025 11:54
@psmagin psmagin requested review from viacheslavkol, mukhiddin-yusuf and SvitlanaKovalova1 and removed request for a team January 17, 2025 11:54
@psmagin psmagin force-pushed the feature/call-number-browse-v2 branch from 346cef8 to 907173e Compare January 17, 2025 13:44
@psmagin psmagin force-pushed the feature/call-number-browse-v2 branch from 907173e to 4ca30f7 Compare January 21, 2025 10:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@psmagin psmagin merged commit 0605e0c into feature/call-number-browse-v2 Jan 21, 2025
5 of 6 checks passed
@psmagin psmagin deleted the MSEARCH-940 branch January 21, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viacheslavkol viacheslavkol viacheslavkol approved these changes

@mukhiddin-yusuf mukhiddin-yusuf mukhiddin-yusuf approved these changes

@SvitlanaKovalova1 SvitlanaKovalova1 SvitlanaKovalova1 approved these changes

Assignees

@psmagin psmagin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psmagin @viacheslavkol @mukhiddin-yusuf @SvitlanaKovalova1