Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api-docs): Fix documentation not being updated #736

Merged
merged 7 commits into from
Jan 22, 2025

Conversation

viacheslavkol
Copy link
Contributor

@viacheslavkol viacheslavkol commented Jan 21, 2025

Purpose

Fix documentation not being updated

Approach

Fix generated filename

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MSEARCH-937

Learning and Resources (if applicable)

Documentation was properly generated/updated and uploaded to s3, but link on dev.folio.org was pointing to the old file being mod-search.html while new documentation was generated as openapi.html.

@viacheslavkol viacheslavkol merged commit b57abdd into master Jan 22, 2025
8 checks passed
@viacheslavkol viacheslavkol deleted the MSEARCH-937 branch January 22, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants