Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODSOURMAN-1246 Data import completion notifications #946

Merged
merged 15 commits into from
Nov 15, 2024
Merged

MODSOURMAN-1246 Data import completion notifications #946

merged 15 commits into from
Nov 15, 2024

Conversation

JavokhirAbdullayev
Copy link
Contributor

@JavokhirAbdullayev JavokhirAbdullayev commented Nov 12, 2024 •
edited
Loading

Purpose

MODSOURMAN-1246 Data import completion notifications

Approach

  • publish event
  • fix tests

Is this change testable? If not - why?

Checklist

  • I have updated NEWS.md.
  • I have added javadocs to new methods.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation e.g. README.md.
  • I have ran karate tests against this feature.

@JavokhirAbdullayev JavokhirAbdullayev marked this pull request as draft November 12, 2024 09:00
@JavokhirAbdullayev JavokhirAbdullayev marked this pull request as ready for review November 13, 2024 06:20
KaterynaSenchenko
KaterynaSenchenko approved these changes Nov 14, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JavokhirAbdullayev JavokhirAbdullayev merged commit ac44ce9 into master Nov 15, 2024
6 checks passed
@JavokhirAbdullayev JavokhirAbdullayev deleted the MODSOURMAN-1246 branch November 15, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aliaksandr-Fedasiuk Aliaksandr-Fedasiuk Aliaksandr-Fedasiuk approved these changes

@dmytrokrutii dmytrokrutii dmytrokrutii approved these changes

@KaterynaSenchenko KaterynaSenchenko KaterynaSenchenko approved these changes

@VRohach VRohach Awaiting requested review from VRohach

@RuslanLavrov RuslanLavrov Awaiting requested review from RuslanLavrov

@RomanChernetskyi RomanChernetskyi Awaiting requested review from RomanChernetskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JavokhirAbdullayev @Aliaksandr-Fedasiuk @dmytrokrutii @KaterynaSenchenko