MODSOURMAN-1203 Add additional validation before marc bib record saving #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrokrutii
requested review from
RuslanLavrov,
RomanChernetskyi,
Aliaksandr-Fedasiuk,
VRohach,
JavokhirAbdullayev and
KaterynaSenchenko
| import static org.folio.services.util.AdditionalFieldsUtil.TAG_999; | ||
| import static org.folio.services.util.AdditionalFieldsUtil.addFieldToMarcRecord; | ||
| import static org.folio.services.util.AdditionalFieldsUtil.getFieldFromMarcRecord; | ||
| import static org.folio.services.util.AdditionalFieldsUtil.*; |
There was a problem hiding this comment.
@dmytrokrutii, please, return single class import.
KaterynaSenchenko
approved these changes
Aug 28, 2024
RuslanLavrov
approved these changes
Aug 28, 2024
Aliaksandr-Fedasiuk
approved these changes
Aug 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add validation on MARC_BIB record save
Approach
Validate that record has externalInstanceId, externalHrId, and 001 field in parsed record content.
TODOS and Open Questions
Learning
MODSOURMAN-1203