Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STCLI-250 omit unused arguments when calling okToPull #355

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

STCLI-250 omit unused arguments when calling okToPull #355

wants to merge 2 commits into from

Commits on Sep 17, 2024

  1. STCLI-250 omit unused arguments when calling okToPull 

    `okToPull()` does not take any arguments so don't call it with any.
SonarCloud noticed we had code like this:
```
foo(arg) {
  const x = blah(arg);
  const okToPull = () => { x.method(); }
  okToPull(arg);
}
```
And got scared.

Refs STCLI-250
    @zburke
    zburke committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3dcd9a3 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge branch 'master' into STCLI-250

    @zburke
    zburke committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    91a3c97 View commit details
    Browse the repository at this point in the history